[Web] Add resource kind-specific sidenav sections #47882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudream
added
the
no-changelog
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
gzdunek
reviewed
Oct 24, 2024
web/packages/teleport/src/Navigation/SideNavigation/Navigation.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/components/hooks/useUrlFiltering/useUrlFiltering.ts
Outdated
Show resolved
Hide resolved
web/packages/teleterm/src/ui/DocumentAccessRequests/NewRequest/useNewRequest.ts
Outdated
Show resolved
Hide resolved
rudream
force-pushed
the
yassine/side-nav-resource-types
branch
from
7b5520c to
488e412
Compare
rudream
force-pushed
the
yassine/side-nav-resource-types
branch
from
488e412 to
ba9e9a7
Compare
gzdunek
reviewed
Oct 25, 2024
web/packages/teleport/src/Navigation/SideNavigation/ResourcesSection.tsx
Show resolved
Hide resolved
avatus
approved these changes
Oct 25, 2024
gzdunek
approved these changes
Oct 25, 2024
rudream
force-pushed
the
yassine/side-nav-resource-types
branch
from
ba9e9a7 to
20d783b
Compare
public-teleport-github-review-bot
bot
removed the request for review
from kiosion
rudream
force-pushed
the
yassine/side-nav-resource-types
branch
from
20d783b to
3332972
Compare
rudream
force-pushed
the
yassine/side-nav-resource-types
branch
2 times, most recently
from
f84f607 to
a4e916a
Compare
rudream
force-pushed
the
yassine/side-nav-resource-types
branch
from
a4e916a to
bc98e26
Compare
rudream
added a commit
that referenced
this pull request
Oct 28, 2024
* add resource kind-specific nav sections * update eref
rudream
added a commit
that referenced
this pull request
Oct 28, 2024
rudream
added a commit
that referenced
this pull request
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Part of https://github.com/gravitational/teleport.e/issues/3998
This PR adds resource kind-specific sidenav shortcuts, allowing users to quickly filter for resource kinds as well as pinned resources from the sidenav. They have also been added to the search.
For more details and context on the way this interacts with the user preference for pinned resources, see the slack discussion here.
Demo
resources-sidenav.mov