Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds caching support for Identity Center resources #47880

Merged
merged 7 commits into from
Oct 28, 2024

Conversation

tcsc
Copy link
Contributor

@tcsc tcsc commented Oct 24, 2024

No description provided.

@tcsc tcsc added the no-changelog Indicates that a PR does not require a changelog entry label Oct 24, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-47880.d212ksyjt6y4yg.amplifyapp.com

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-47880.d3pp5qlev8mo18.amplifyapp.com

@tcsc tcsc requested a review from smallinsky October 24, 2024 05:22
@tcsc tcsc force-pushed the tcsc/ic-resource-caching branch 2 times, most recently from a75d6e0 to 0f39f70 Compare October 24, 2024 07:35
Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a lot of this is just boilerplate so I've only done a cursory scan.

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from fspmarshall October 28, 2024 01:35
@tcsc tcsc enabled auto-merge October 28, 2024 02:07
@tcsc tcsc disabled auto-merge October 28, 2024 02:08
@tcsc tcsc changed the title Adds caching support for Identity Ceneter resources Adds caching support for Identity Center resources Oct 28, 2024
tcsc added 2 commits October 28, 2024 13:30
Adds support for caching (and watching) some IdentityCenter resource types.

Specifically:
 - identitycenterv1.Account
 - identitycenterv1.AccountAsssignment
 - identitycenterv1.PrincipalAssignment

Also breaks the cache's `genericcollection` out into its own file as an attempt
to reduce clutter in the main collections source file.
@tcsc tcsc force-pushed the tcsc/ic-resource-caching branch from e271eba to 5d3e11f Compare October 28, 2024 02:31
@tcsc tcsc enabled auto-merge October 28, 2024 02:32
@tcsc tcsc added this pull request to the merge queue Oct 28, 2024
Merged via the queue into master with commit 54c9060 Oct 28, 2024
43 checks passed
@tcsc tcsc deleted the tcsc/ic-resource-caching branch October 28, 2024 12:38
tcsc added a commit that referenced this pull request Oct 29, 2024
* Adds caching support for Identity Center resources

Adds support for caching (and watching) some IdentityCenter resource types.

Specifically:
 - identitycenterv1.Account
 - identitycenterv1.AccountAsssignment
 - identitycenterv1.PrincipalAssignment

Also breaks the cache's `genericcollection` out into its own file as an attempt
to reduce clutter in the main collections source file.

* Update identitycenter_events.go

* Update identitycenter_events.go

* Speed up tests
github-merge-queue bot pushed a commit that referenced this pull request Oct 29, 2024
* Adds caching support for Identity Center resources

Adds support for caching (and watching) some IdentityCenter resource types.

Specifically:
 - identitycenterv1.Account
 - identitycenterv1.AccountAsssignment
 - identitycenterv1.PrincipalAssignment

Also breaks the cache's `genericcollection` out into its own file as an attempt
to reduce clutter in the main collections source file.

* Update identitycenter_events.go

* Update identitycenter_events.go

* Speed up tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/lg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants