Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename useWebAuthn to useMfa and handle SSO challenges #47819

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Conversation

avatus
Copy link
Contributor

@avatus avatus commented Oct 22, 2024

This PR is mostly a rename/refactor. SSO challenges will still not be received until SSO as MFA is merged.

The reason for this change is to have a single hook that can handle/response to all challenge types instead of just webauthn. So now we can have all of our MFA logic in useMfa instead.

Will follow the backports needed for the entire feature when that time comes.

@avatus avatus added the no-changelog Indicates that a PR does not require a changelog entry label Oct 22, 2024
@avatus avatus requested review from Joerger and kimlisa October 22, 2024 18:18
@avatus avatus changed the title Update useWebAuthn to useMfa and handle SSO challenges Rename useWebAuthn to useMfa and handle SSO challenges Oct 22, 2024
@github-actions github-actions bot requested review from kiosion and ravicious October 22, 2024 18:19
@avatus avatus removed the request for review from ravicious October 22, 2024 18:19
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-47819.d3pp5qlev8mo18.amplifyapp.com

@avatus avatus requested a review from ryanclark October 23, 2024 12:46
@avatus avatus added this pull request to the merge queue Oct 23, 2024
Merged via the queue into master with commit 8829746 Oct 23, 2024
40 checks passed
@avatus avatus deleted the avatus/usemfa branch October 23, 2024 13:34
@Joerger Joerger mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants