Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application access section to the role editor #47803

Merged
merged 22 commits into from
Oct 25, 2024
Merged

Conversation

bl-nero
Copy link
Contributor

@bl-nero bl-nero commented Oct 22, 2024

Screenshot 2024-10-22 at 16 21 13

Figma

Deviations from the design:

  • Used a new multi-value input to better handle lengthy values.
  • The buttons are a bit larger than designed to maintain consistency for now. Will make them smaller later, together with the label editor.

Requires #47804.

@bl-nero bl-nero added the no-changelog Indicates that a PR does not require a changelog entry label Oct 22, 2024
@bl-nero bl-nero marked this pull request as ready for review October 22, 2024 14:23
@github-actions github-actions bot requested review from kiosion and ryanclark October 22, 2024 14:24
Base automatically changed from bl-nero/multi-input to master October 24, 2024 15:39
// Index of the input to be focused after the next rendering.
const toFocus = useRef<number | undefined>();

const setFocus = element => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

element needs a type

@bl-nero bl-nero enabled auto-merge October 25, 2024 14:51
@bl-nero bl-nero added this pull request to the merge queue Oct 25, 2024
Merged via the queue into master with commit cd93b25 Oct 25, 2024
39 checks passed
@bl-nero bl-nero deleted the bl-nero/role-editor-5 branch October 25, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/md ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants