Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover Wizard: drop v13 edge case for Kube Access #47790

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Discover Wizard: drop v13 edge case for Kube Access #47790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions web/packages/teleport/src/Discover/Kubernetes/HelmChart/HelmChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,14 +365,6 @@ export function generateCmd(data: GenerateCmdProps) {
// AutomaticUpgradesTargetVersion contains a v, eg, v13.4.2.
// However, helm chart expects no 'v', eg, 13.4.2.
deployVersion = data.automaticUpgradesTargetVersion.replace(/^v/, '');

// TODO(marco): remove when stable/cloud moves to v14
// For v13 releases of the helm chart, we must remove the App role.
// We get the following error otherwise:
// Error: INSTALLATION FAILED: execution error at (teleport-kube-agent/templates/statefulset.yaml:26:28): at least one of 'apps' and 'appResources' is required in chart values when app role is enabled, see README
if (deployVersion.startsWith('13.')) {
roles = ['Kube'];
}
}

const yamlRoles = roles.join(',').toLowerCase();
Expand Down
Loading