resolve minor TODOs #47777
Merged
resolve minor TODOs #47777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklaassen
added
the
no-changelog
nklaassen
commented
Oct 22, 2024
Comment on lines
-291
to
-292
| // TODO(nklaassen): consider recording both public keys once they are | ||
| // actually separated. |
There was a problem hiding this comment.
tbot always uses the same key for SSH and TLS when it requests both
nklaassen
commented
Oct 22, 2024
| @@ -1240,7 +1240,6 @@ func checkResourceConsistency(ctx context.Context, keyStore *keystore.Manager, c | |||
|
|
|||
| // GenerateIdentity generates identity for the auth server | |||
| func GenerateIdentity(a *Server, id state.IdentityID, additionalPrincipals, dnsNames []string) (*state.Identity, error) { | |||
| // TODO(nklaassen): split SSH and TLS keys for host identities. | |||
There was a problem hiding this comment.
not splitting SSH/TLS keys for host identities
| @@ -100,7 +100,6 @@ const ( | |||
| // HostSSH represents a host SSH key. | |||
| HostSSH | |||
| // HostIdentity represents a key used for a Teleport host identity. | |||
| // TODO(nklaassen): split SSH and TLS keys used for host identities. | |||
There was a problem hiding this comment.
not splitting SSH/TLS keys for host identities
Comment on lines
-116
to
-117
| // TODO(nklaassen): request only an SSH cert, we don't need TLS here. | ||
| // GenerateHostCert needs support for this. |
There was a problem hiding this comment.
it already does this idk why i wrote this TODO
rosstimothy
approved these changes
Oct 22, 2024
marcoandredinis
approved these changes
Oct 22, 2024
public-teleport-github-review-bot
bot
removed request for
fspmarshall and
camscale
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
🤖 Vercel preview here: https://docs-m62dh3yk1-goteleport.vercel.app/docs/ver/preview |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.