[Web] Fix error when using sidenav search while on non-sidenav section #47772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudream
added
the
no-changelog
avatus
approved these changes
Oct 21, 2024
flyinghermit
approved these changes
Oct 21, 2024
public-teleport-github-review-bot
bot
removed request for
ravicious and
gzdunek
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ravicious
reviewed
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the search which didn't handle
currentViewbeing undefined, which occurs when the user is on a page which isn't part of the sidenav (such asAccount Settings).currentViewis intended to represent the current sidenav section that the user is on, this is used to highlight that section in the sidenav to indicate it as being active. This meant that using the sidenav search while on one of those pages would trigger an error, since it would be a page not on the sidenav and thuscurrentViewwould be undefined.