Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v17] OIDC: validate the client_secret field #47751

Closed
wants to merge 1 commit into from
Closed

[v17] OIDC: validate the client_secret field #47751

wants to merge 1 commit into from

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Oct 21, 2024

  • Make the client_secret required, as OIDC auth won't work without it
  • Raise a clear error if unsupported file:// URLs are used

Closes #39107

image

Backports #46041

@zmb3
OIDC: validate the client_secret field
31faba5 
- Make the client_secret required, as OIDC auth won't work without it
- Raise a clear error if unsupported file:// URLs are used

Closes #39107
@github-actions github-actions bot added backport size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Oct 21, 2024
@github-actions github-actions bot requested review from camscale and kimlisa October 21, 2024 13:40
@r0mant r0mant deleted the branch branch/v17 October 21, 2024 14:41
@r0mant r0mant closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camscale camscale Awaiting requested review from camscale

@kimlisa kimlisa Awaiting requested review from kimlisa

Assignees
No one assigned
Labels
backport size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zmb3 @r0mant