Web: rename generic variable name to a helpful name #47722
Conversation
kimlisa
added
no-changelog
public-teleport-github-review-bot
bot
removed the request for review
from kiosion
There was a problem hiding this comment.
Continuing on the topic started in my comment (#47347 (comment)), this is a good start and it addresses the point I had about data being a vague term. Long term we'd need to address things like
AccessRequestCheckout receiving unfiltered data and then filtering it again.
What I was getting onto in that comment is that there are concepts in the code waiting to be discovered and given names. Resorting to using terms like "data" means that the next person reading that code will have to figure out what's what by themselves.
I'm yet to use the actual UI you've built in those PRs myself, but from reading the code, it seems that there are some items within pendingAccessRequests that are meant to be used when rendered on screen and some that are meant to be used when communicating with the backend. If that's the case, then those items are good examples of two specific concepts for which we could find specific names. Sometimes prepending a variable name with an adjective (e.g. data and filteredData) can only do so much and we have invent new concepts to move forward.
* Web: rename generic variable name to a helpful name (#47722) * Update snap
part of #46742
as a result of comment: #47345 (comment)
separated to reduce noise