Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match SideNavigation scrollbars to theme #47690

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

kiosion
Copy link
Contributor

@kiosion kiosion commented Oct 17, 2024

Tiny fix. Add scrollbar-color to SideNavigation panels so scrollbars don't stand out when not needed

@kiosion kiosion added the no-changelog Indicates that a PR does not require a changelog entry label Oct 17, 2024
@github-actions github-actions bot requested review from kimlisa and rudream October 17, 2024 23:02
@ryanclark
Copy link
Contributor

What do you think about adding data-scrollbar="default" to the element instead? It restores the browser's scrollbars. I'm not sure why we override the scrollbar and make it look awful

@kiosion
Copy link
Contributor Author

kiosion commented Oct 22, 2024

What do you think about adding data-scrollbar="default" to the element instead? It restores the browser's scrollbars. I'm not sure why we override the scrollbar and make it look awful

do we? I didn't see any existing CSS targeting scrollbar or -webkit-scrollbar, less I missed smth

I'll see if just adding that does the trick though.
Edit: Doesn't seem to.

@kiosion kiosion force-pushed the maxim/update-nav-scrollbar-style branch from 75edada to 788927d Compare October 24, 2024 23:34
@kiosion kiosion added this pull request to the merge queue Oct 25, 2024
Merged via the queue into master with commit 43229d5 Oct 25, 2024
39 checks passed
@kiosion kiosion deleted the maxim/update-nav-scrollbar-style branch October 25, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants