Add autoupdate agent protos #47666
Merged
Add autoupdate agent protos #47666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
force-pushed
the
hugo/autoupdate-agent-second-take
branch
from
82bb35e to
b3baa26
Compare
hugoShaka
added
the
no-changelog
sclevine
approved these changes
Oct 18, 2024
vapopov
approved these changes
Oct 18, 2024
hugoShaka
force-pushed
the
hugo/autoupdate-agent-second-take
branch
from
a185e89 to
657b60a
Compare
rosstimothy
reviewed
Oct 21, 2024
Co-authored-by: rosstimothy <[email protected]>
rosstimothy
approved these changes
Oct 21, 2024
public-teleport-github-review-bot
bot
removed request for
nklaassen and
fheinecke
sclevine
approved these changes
Oct 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take no 2 to add autoupdate agent protobuf types, from RFD #47126
I did not add every field (e.g. canaris are missing, max in flight as well, ...). This will avoid users to be exposed to not-yet-implemented fields and features