Remove SolveAuthenticateChallenge from MFA Ceremony in favor of PromptConstructor
#47650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joerger
added
no-changelog
marcoandredinis
approved these changes
Oct 17, 2024
Co-authored-by: Marco Dinis <[email protected]>
probakowski
approved these changes
Oct 18, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
…romptConstructor` (#47650) * Remove mfa.Ceremony.SolveChallenge in favor of PromptFunc. * Update api/mfa/ceremony.go Co-authored-by: Marco Dinis <[email protected]> --------- Co-authored-by: Marco Dinis <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Joerger
added a commit
that referenced
this pull request
Oct 21, 2024
…romptConstructor` (#47650) * Remove mfa.Ceremony.SolveChallenge in favor of PromptFunc. * Update api/mfa/ceremony.go Co-authored-by: Marco Dinis <[email protected]> --------- Co-authored-by: Marco Dinis <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
…romptConstructor` (#47650) (#47769) * Remove mfa.Ceremony.SolveChallenge in favor of PromptFunc. * Update api/mfa/ceremony.go --------- Co-authored-by: Marco Dinis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the extra (
SolveAuthenticateChallenge) field MFA ceremony, as it had few callers and can be replaced by a static prompt constructor instead:Prerequisite for some SSO MFA changes to follow, which pass some SSO info as prompt opts.
Follow up to #46986