Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update table to mark which roles are ent and community preset #47646

Merged
merged 3 commits into from
Oct 21, 2024
Merged

docs: update table to mark which roles are ent and community preset #47646

merged 3 commits into from
Oct 21, 2024

Conversation

stevenGravy
Copy link
Contributor

This didn't capture all of which were ent and/or community. Using checkmark approach.

@stevenGravy stevenGravy added backport/branch/v14 no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 backport/branch/v16 labels Oct 16, 2024
@stevenGravy stevenGravy enabled auto-merge October 16, 2024 20:11
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-ifex8j40u-goteleport.vercel.app/docs/ver/preview

ptgott
ptgott reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@ptgott ptgott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since all roles are available in Enterprise, would it make sense to use one column for edition availability, e.g., "Enterprise-only"?

@stevenGravy
Copy link
Contributor Author

Since all roles are available in Enterprise, would it make sense to use one column for edition availability, e.g., "Enterprise-only"?

sure, please see update @ptgott

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-atteczgft-goteleport.vercel.app/docs/ver/preview

ptgott
ptgott approved these changes Oct 21, 2024
View reviewed changes
docs/pages/includes/preset-roles-table.mdx Outdated Show resolved Hide resolved
@stevenGravy @ptgott
docs: table update for roles
0eea870 
Co-authored-by: Paul Gottschling <[email protected]>
@stevenGravy stevenGravy disabled auto-merge October 21, 2024 14:46
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-5hicbatqy-goteleport.vercel.app/docs/ver/preview

scottpgallagher
scottpgallagher approved these changes Oct 21, 2024
View reviewed changes
Copy link

@scottpgallagher scottpgallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@stevenGravy stevenGravy added this pull request to the merge queue Oct 21, 2024
Merged via the queue into master with commit fba471a Oct 21, 2024
40 checks passed
@stevenGravy stevenGravy deleted the stevenGravy/docs/roletable branch October 21, 2024 15:58
@public-teleport-github-review-bot
Copy link

@stevenGravy See the table below for backport results.

Branch Result
branch/v15 Create PR
branch/v16 Create PR

This was referenced Oct 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottpgallagher scottpgallagher scottpgallagher approved these changes

@ptgott ptgott ptgott approved these changes

@mmcallister mmcallister Awaiting requested review from mmcallister

@r0mant r0mant Awaiting requested review from r0mant

@xinding33 xinding33 Awaiting requested review from xinding33

@zmb3 zmb3 Awaiting requested review from zmb3

Assignees
No one assigned
Labels
backport/branch/v15 backport/branch/v16 documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenGravy @ptgott @scottpgallagher