[v16] Create DiscoverEC2 User Tasks when Auto Discover fails on EC2 instances #47618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
added
the
no-changelog
strideynet
approved these changes
Oct 16, 2024
marcoandredinis
force-pushed
the
bot/backport-47064-branch/v16
branch
4 times, most recently
from
161cea9 to
9549692
Compare
marcoandredinis
force-pushed
the
bot/backport-47064-branch/v16
branch
from
9549692 to
8c285fd
Compare
r0mant
approved these changes
Oct 25, 2024
This PR changes the DiscoveryService to start creating and updating Discover EC2 User Tasks. So, what are Discover EC2 User Tasks? When users set up Auto Discover for EC2 Instances, they don't have a good way of checking for issues on their configured matchers. We created User Tasks as a way to warn Users that something's wrong. Each User Task should describe an issue that happened and a way to fix it. This has potential to be used to report unexpected events trough the whole system, which are not errors per se, but something the user should take action in order to improve the situation. In this case, we are creating a sub type of those tasks: DiscoverEC2. From now on, when the DiscoveryService fails to auto-enroll an instance, it will create a DiscoverEC2 User Task grouping all the failed instances by the following props: - integration - issue type - account id - region A follow up PR will also create notifications so that the user can actually be notified on those User Tasks and take action.
) This PR adds two new fields to the DiscoverEC2 User Task. SSM Document used to install teleport Teleport Installer script name used to install teleport This can be used to let the user know which scripts were used. For the SSM Document, users can then open it in webui. For the Installer Script, users can manage it using `tctl` client.
marcoandredinis
force-pushed
the
bot/backport-47064-branch/v16
branch
from
8c285fd to
5d043a6
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #47064 #47626 and #47712 to branch/v16