Prevent deleting last passwordless device with no password #47592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallinsky
approved these changes
Oct 16, 2024
codingllama
approved these changes
Oct 16, 2024
| @@ -3880,11 +3880,11 @@ func (a *Server) deleteMFADeviceSafely(ctx context.Context, user, deviceName str | |||
| // Check whether the device to delete is the last passwordless device, | |||
| // and whether deleting it would lockout the user from login. | |||
| // | |||
| // TODO(Joerger): the user may already be locked out from login if a password | |||
| // Note: the user may already be locked out from login if a password | |||
There was a problem hiding this comment.
As you said, it's a pretty weird edge case, but I think I'm OK with the if essentially saying "is last passkey && has no password".
public-teleport-github-review-bot
bot
removed request for
bl-nero and
atburke
|
Note: depends on #47426. Please wait for the base PR to be merged before merging this one (naturally). |
Joerger
force-pushed
the
joerger/prevent-transitory-passwordless-lockout
branch
from
3c36234 to
4baf9f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent users from deleting their last passwordless device if they have no other means of logging in, even if passwordless is currently disabled. This way, if passwordless is re-enabled, the user will be able to log in.
I found this small logic edge case while creating #47426 and figured it may as well be covered.
Honestly, after giving this more thought and seeing the change on its merit, this may be a distinction without a difference. In practice the user will probably need to be reset anyways, except for the hard to imagine edge case:
Changelog: Update logic around deleting last passkey to prevent edge case lockouts.