UserNotifications: add UpsertGlobalNotification #47558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the UpsertGlobalNotification method. It allows clients to create and update GlobalNotifications. This is required for the UserTasks. The goal is to let the user know that they have a pending user tasks for a given integration. Instead of creating multiple notifications, we create a single one with a specific user name. Everytime we try to create another notification for that integration, it will just issue an Upsert and only update the expiration.
marcoandredinis
added
no-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the UpsertGlobalNotification method.
It allows clients to create and update GlobalNotifications.
This is required for the UserTasks.
The goal is to let the user know that they have a pending user tasks for a given integration.
Instead of creating multiple notifications, we create a single one with a specific user name.
Everytime we try to create another notification for that integration, it will just issue an Upsert and only update the expiration.