Add resource matchers to Windows desktop service config #46985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
probakowski
added
the
no-changelog
jakule
approved these changes
Oct 1, 2024
zmb3
approved these changes
Oct 1, 2024
public-teleport-github-review-bot
bot
removed the request for review
from atburke
…r-resources-proto
…r-resources-proto
…register-resources-config
…register-resources-config
…r-resources-proto
Co-authored-by: rosstimothy <[email protected]>
…r-resources-proto
…r-resources-proto
Base automatically changed from
probakowski/register-resources-proto
to
master
October 14, 2024 18:39
r0mant
approved these changes
Oct 14, 2024
rosstimothy
approved these changes
Oct 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mvbrock
pushed a commit
that referenced
this pull request
Oct 16, 2024
* Add DynamicWindowsDesktop to proto * Add resource matchers to Windows desktop service config * move rpc to separate server * e * remove dynamic windows from paginated resource * Update api/proto/teleport/legacy/types/types.proto Co-authored-by: rosstimothy <[email protected]> * gci --------- Co-authored-by: rosstimothy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource matchers will be used for dynamic registration of windows desktops (#37103)
This is part of splitting #46738 into smaller, easier to review, PRs