Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check AMRs are being watched before initialising cache #46938

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+12 −2
Open

Add check AMRs are being watched before initialising cache #46938

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67b9c80
Add check AMRs are being watched before initialising cache
EdwardDowling Sep 26, 2024
00cfa42
Merge branch 'master' into edwarddowling/pagerduty-tpclient-init
EdwardDowling Sep 27, 2024
a04e4bc
Merge branch 'master' into edwarddowling/pagerduty-tpclient-init
EdwardDowling Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions integrations/access/pagerduty/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (
"context"
"errors"
"fmt"
"slices"
"strings"
"time"

Expand Down Expand Up @@ -140,8 +141,17 @@ func (a *App) run(ctx context.Context) error {
if err != nil {
return trace.Wrap(err)
}
if err := a.accessMonitoringRules.InitAccessMonitoringRulesCache(ctx); err != nil {
return trace.Wrap(err)

if len(acceptedWatchKinds) == 0 {
return trace.BadParameter("failed to initialize watcher for all the required resources: %+v",
watchKinds)
}
// Check if KindAccessMonitoringRule resources are being watched,
// the role the plugin is running as may not have access.
if slices.Contains(acceptedWatchKinds, types.KindAccessMonitoringRule) {
if err := a.accessMonitoringRules.InitAccessMonitoringRulesCache(ctx); err != nil {
return trace.Wrap(err, "initializing Access Monitoring Rule cache")
}
}

a.mainJob.SetReady(ok)
Expand Down
Loading