Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: add a tooltip summary for aws oidc configure step #46934

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

kimlisa
Copy link
Contributor

@kimlisa kimlisa commented Sep 26, 2024

this is for enrolling aws oidc integration flow

checkout story: https://localhost:9003/?path=/story/teleport-integrations-enroll-awsoidc--flow

image

@kimlisa kimlisa added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 backport/branch/v16 labels Sep 26, 2024
@zmb3
Copy link
Collaborator

zmb3 commented Sep 28, 2024

Is there a better way to display the IAM role? The editor feels too big for a tooltip, and having two scrollbars show up feels like a poor UX.

@GavinFrazar
Copy link
Contributor

GavinFrazar commented Sep 30, 2024

The script will describe specifics like the trust policy. I think the UI tooltip should just summarize in plain sentences

@thedevelopnik
Copy link
Contributor

Is there a better way to display the IAM role? The editor feels too big for a tooltip, and having two scrollbars show up feels like a poor UX.

Yeah, I think it could just be something like "configures an IAM role called iam-role-name that allows it to assume a role."

@samratambadekar samratambadekar self-assigned this Oct 3, 2024
@r0mant
Copy link
Collaborator

r0mant commented Oct 4, 2024

I think showing the IAM policy here would be helpful too, for user reference. Can we borrow the "sliding out side panel" UX trick from TAG and show it in the panel that slides off of the right edge to view the full policy?

@kimlisa kimlisa force-pushed the lisa/add-clarifying-tool-tip-aws-oidc branch from 754f60d to 06d35a3 Compare November 13, 2024 19:42
@kimlisa
Copy link
Contributor Author

kimlisa commented Nov 13, 2024

i discussed this with kenny, xin, and dave:

we agreed to keep the tooltip for now (with wider width, to reduce horizontal scrolling), until we finalize how we want to better represent these type of information eg: side bar. (there are other places in discover where we use same tooltip for similar info)

@kimlisa kimlisa force-pushed the lisa/add-clarifying-tool-tip-aws-oidc branch from 06d35a3 to f7744ac Compare November 13, 2024 19:50
@zmb3
Copy link
Collaborator

zmb3 commented Nov 13, 2024

Sounds good to me.

(Some day we really should get the ACE editor to use a light syntax theme when Teleport is in light mode).

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from rudream November 13, 2024 22:51
@kimlisa kimlisa added this pull request to the merge queue Nov 14, 2024
Merged via the queue into master with commit 5b74d41 Nov 14, 2024
39 checks passed
@kimlisa kimlisa deleted the lisa/add-clarifying-tool-tip-aws-oidc branch November 14, 2024 03:19
@public-teleport-github-review-bot

@kimlisa See the table below for backport results.

Branch Result
branch/v16 Failed
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v16 backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants