Fix panic in pagerduty plugin init phase
#46924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a problem caused by pagerduty not having the Teleport client initialized when starting from the standalone plugin. This PR fixes the issue by moving the access monitoring rules init function to a place where the teleport client is already initialized. Signed-off-by: Tiago Silva <[email protected]>
hugoShaka
approved these changes
Sep 25, 2024
camscale
approved these changes
Sep 25, 2024
public-teleport-github-review-bot
bot
removed the request for review
from marcoandredinis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem caused by pagerduty not having the Teleport client initialized when starting from the standalone plugin.
This PR fixes the issue by moving the access monitoring rules init function to a place where the teleport client is already initialized.
Changelog: Fixes a panic when using the self-hosted PagerDuty plugin.