Remove oxy connections limiter #46900
Conversation
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
zmb3
force-pushed
the
zmb3/remove-oxy
branch
from
f7c2646 to
55025b3
Compare
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
|
|
||
| // Wrap wraps an HTTP handler. | ||
| func (l *ConnectionsLimiter) Wrap(h http.Handler) { | ||
| l.next = h |
There was a problem hiding this comment.
I don't like this approach, a second call to Wrap is going to overwrite the first one and we might do that by accident, we could return a http.Handler from Wrap instead (with an inline http.HandlerFunc maybe):
func (l *ConnectionsLimiter) Wrap(next http.Handler) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
token, _, err := net.SplitHostPort(r.RemoteAddr)
...
if err := l.AcquireConnection(token); err != nil {
...
}
defer l.ReleaseConnection(token)
next.ServeHTTP(w, r)
})
}There was a problem hiding this comment.
I don't love it either, it's just how this code already worked.
zmb3
force-pushed
the
zmb3/remove-oxy
branch
from
55025b3 to
57f2bec
Compare
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
public-teleport-github-review-bot
bot
removed the request for review
from eriktate
zmb3
force-pushed
the
zmb3/remove-oxy
branch
from
57f2bec to
b5dea7c
Compare
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
zmb3
force-pushed
the
zmb3/remove-oxy
branch
from
b5dea7c to
ccc4e63
Compare
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
zmb3
force-pushed
the
zmb3/remove-oxy
branch
from
ccc4e63 to
12db2df
Compare
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
zmb3
added
the
no-changelog
lib/limiter composes a maximum simultaneous connections limiter as well as a rate limiter. This commit replaces the connections limiter from oxy with built-in code. Note: this also introduces a bug fix that may change behavior. Prior to this change, the connection limiter kept a separate connection account for HTTP connections than it did for connections managed manually with acquire/release. We no longer maintain separate counts - all connections (HTTP or not) contribute to the number of allowed connections.
zmb3
force-pushed
the
zmb3/remove-oxy
branch
from
12db2df to
7b8573e
Compare
lib/limiter composes a maximum simultaneous connections limiter as well as a rate limiter. This commit replaces the connections limiter from oxy with built-in code.
Note: this also introduces a bug fix that may change behavior. Prior to this change, the connection limiter kept a separate connection account for HTTP connections than it did for connections managed manually with acquire/release. We no longer maintain separate counts - all connections (HTTP or not) contribute to the number of allowed connections.