Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated GetSessionChunk and GetSessionEvents APIs #46797

Merged
merged 14 commits into from
Sep 23, 2024
Merged

Remove deprecated GetSessionChunk and GetSessionEvents APIs #46797

merged 14 commits into from
Sep 23, 2024

Conversation

strideynet
Copy link
Contributor

@strideynet strideynet commented Sep 20, 2024 •
edited
Loading

What started as trying to remove these APIs from the Auth Server HTTP API, quickly unravelled to reveal a bunch of code that could be deleted.

I'm not 100% certain on the changes I've made to the integrations tests, so would appreciate a closer eye on those to make sure I'm still asserting the same things.

@strideynet strideynet changed the title Start hacking on removing deprecated session api Remove deprecated GetSessionChunk and GetSessionEvents APIs Sep 20, 2024
@strideynet strideynet added the no-changelog Indicates that a PR does not require a changelog entry label Sep 20, 2024
@zmb3
Copy link
Collaborator

zmb3 commented Sep 20, 2024

quickly unravelled to reveal a bunch of code that could be deleted

Welcome to lib/events! :-)

@strideynet strideynet marked this pull request as ready for review September 20, 2024 14:21
@github-actions github-actions bot added audit-log Issues related to Teleports Audit Log size/sm ui labels Sep 20, 2024
zmb3
zmb3 reviewed Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need WriteForSSHPlayback or SSHPlaybackWriter?

integration/integration_test.go Show resolved Hide resolved
integration/integration_test.go Outdated Show resolved Hide resolved
lib/events/sessionlog.go Outdated Show resolved Hide resolved
@strideynet strideynet requested a review from zmb3 September 20, 2024 16:04
zmb3
zmb3 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I'll run it a bit this afternoon as well to see if antyhing looks off.

Note: there's a mention of GetSessionEvents in a comment in lib/events/complete.go that can be removed now that there's no alternate API to be confused by.

rosstimothy
rosstimothy reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@rosstimothy rosstimothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@strideynet strideynet added this pull request to the merge queue Sep 23, 2024
Merged via the queue into master with commit d4bea8c Sep 23, 2024
43 checks passed
@strideynet strideynet deleted the strideynet/remove-deprecated-session-apis branch September 23, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosstimothy rosstimothy rosstimothy approved these changes

@zmb3 zmb3 zmb3 approved these changes

Assignees
No one assigned
Labels
audit-log Issues related to Teleports Audit Log no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@strideynet @zmb3 @rosstimothy