tsh: Deduplicate the list of request IDs #46780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/sm
tsh
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
nklaassen
reviewed
Sep 19, 2024
zmb3
force-pushed
the
zmb3/deduplicate-resource-requests
branch
from
3705873 to
07dbfd4
Compare
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
zmb3
force-pushed
the
zmb3/deduplicate-resource-requests
branch
from
07dbfd4 to
9abd42e
Compare
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
ryanclark
approved these changes
Sep 25, 2024
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
zmb3
force-pushed
the
zmb3/deduplicate-resource-requests
branch
from
6277769 to
3fc59a5
Compare
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
zmb3
added
the
no-changelog
nklaassen
approved these changes
Oct 2, 2024
public-teleport-github-review-bot
bot
removed the request for review
from capnspacehook
nklaassen
approved these changes
Oct 2, 2024
It's possible to specify the same request multiple times with tsh request create. The duplicates eventually get resolved before we generate a certificate, but they do exist in the access request resource. This can cause the size of the resource to exceed the limits of a gRPC message and break listing.
zmb3
force-pushed
the
zmb3/deduplicate-resource-requests
branch
from
9c069a9 to
86a4573
Compare
This was referenced Oct 2, 2024
zmb3
added a commit
that referenced
this pull request
Oct 29, 2024
In #46780 we put a cap on the total number of resources that can be requested in a single request, which helps avoid situations where a large access request can exceed resource size limits and break request listing. This change expands on the validations by also checking that the sum of the lengths of all of the requested IDs stays below a reasonable limit.
zmb3
added a commit
that referenced
this pull request
Oct 29, 2024
In #46780 we put a cap on the total number of resources that can be requested in a single request, which helps avoid situations where a large access request can exceed resource size limits and break request listing. This change expands on the validations by also checking that the sum of the lengths of all of the requested IDs stays below a reasonable limit.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
In #46780 we put a cap on the total number of resources that can be requested in a single request, which helps avoid situations where a large access request can exceed resource size limits and break request listing. This change expands on the validations by also checking that the sum of the lengths of all of the requested IDs stays below a reasonable limit.
github-actions bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
In #46780 we put a cap on the total number of resources that can be requested in a single request, which helps avoid situations where a large access request can exceed resource size limits and break request listing. This change expands on the validations by also checking that the sum of the lengths of all of the requested IDs stays below a reasonable limit.
github-actions bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
In #46780 we put a cap on the total number of resources that can be requested in a single request, which helps avoid situations where a large access request can exceed resource size limits and break request listing. This change expands on the validations by also checking that the sum of the lengths of all of the requested IDs stays below a reasonable limit.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
In #46780 we put a cap on the total number of resources that can be requested in a single request, which helps avoid situations where a large access request can exceed resource size limits and break request listing. This change expands on the validations by also checking that the sum of the lengths of all of the requested IDs stays below a reasonable limit.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
In #46780 we put a cap on the total number of resources that can be requested in a single request, which helps avoid situations where a large access request can exceed resource size limits and break request listing. This change expands on the validations by also checking that the sum of the lengths of all of the requested IDs stays below a reasonable limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to specify the same request multiple times with tsh request create. The duplicates eventually get resolved before we generate a certificate, but they do exist in the access request resource. This can cause the size of the resource to exceed the limits of a gRPC message and break listing.
(I also squeezed in some non-functional changes to the tsh tests as the mix of tabs and spaces was bothering me)