Fix pagerduty AMR test to prevent flakiness #46390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwardDowling
added
no-changelog
tigrato
reviewed
Sep 9, 2024
zmb3
reviewed
Sep 9, 2024
EdwardDowling
force-pushed
the
edwarddowling/paggerduty-flaky-tests
branch
from
a2918c3 to
ec682bc
Compare
nklaassen
approved these changes
Sep 10, 2024
Co-authored-by: Zac Bergquist <[email protected]>
EdwardDowling
force-pushed
the
edwarddowling/paggerduty-flaky-tests
branch
from
56e020c to
24251a1
Compare
tigrato
reviewed
Oct 16, 2024
Co-authored-by: Tiago Silva <[email protected]>
Co-authored-by: Tiago Silva <[email protected]>
zmb3
reviewed
Oct 20, 2024
zmb3
approved these changes
Oct 21, 2024
|
@EdwardDowling See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46253
Changes test to retry until access monitoring rule begins applying as access request creation on the line following the rule creation may result in the plugin seeing the request before its cache of access monitoring rules has been updated.
Could not replicate the test flaking locally with a '-count 5000'