Web Bug Fix: Remove view status button for okta (not fully implemented) #46174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
kimlisa
force-pushed
the
lisa/remove-view-status
branch
from
8b22342 to
5218dc1
Compare
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
r0mant
approved these changes
Sep 3, 2024
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
avatus
approved these changes
Sep 3, 2024
public-teleport-github-review-bot
bot
removed request for
ravicious and
rudream
kimlisa
added
the
no-changelog
This was referenced Sep 3, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
…handler (#46261) * Okta types update * Revert "Remove okta row click handler (not fully implemented) (#46179)" This reverts commit 714c174. * Revert "Remove view status button for okta (not fully implemented) (#46174)" This reverts commit 54a0293. * Require exact route and revert primary route link and text for oidc finish dialog
kimlisa
added a commit
that referenced
this pull request
Sep 10, 2024
…handler (#46261) * Okta types update * Revert "Remove okta row click handler (not fully implemented) (#46179)" This reverts commit 714c174. * Revert "Remove view status button for okta (not fully implemented) (#46174)" This reverts commit 54a0293. * Require exact route and revert primary route link and text for oidc finish dialog
kimlisa
added a commit
that referenced
this pull request
Sep 12, 2024
…handler (#46261) * Okta types update * Revert "Remove okta row click handler (not fully implemented) (#46179)" This reverts commit 714c174. * Revert "Remove view status button for okta (not fully implemented) (#46174)" This reverts commit 54a0293. * Require exact route and revert primary route link and text for oidc finish dialog
kimlisa
added a commit
that referenced
this pull request
Sep 13, 2024
…handler (#46261) * Okta types update * Revert "Remove okta row click handler (not fully implemented) (#46179)" This reverts commit 714c174. * Revert "Remove view status button for okta (not fully implemented) (#46174)" This reverts commit 54a0293. * Require exact route and revert primary route link and text for oidc finish dialog
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
* Web: Add support for client search query params for Table (have to opt in) (#46092) * Add flex basis prop to HoverTooltip * Change encodeUrlQueryParams props to object prop * Add client searching query param support to UserList * Move form submission handler closer to InputSearch Also got rid of showSearchBar, it was always set to true * Update test and minor fixes * Fix story * Address CRs * Fix test * Web: Update okta types and add back okta "view status" and row click handler (#46261) * Okta types update * Revert "Remove okta row click handler (not fully implemented) (#46179)" This reverts commit 714c174. * Revert "Remove view status button for okta (not fully implemented) (#46174)" This reverts commit 54a0293. * Require exact route and revert primary route link and text for oidc finish dialog * Web: fix document node searching (#46506) * Delete unused nodes files * Move search panel out of unified to teleport/src/component The search panel in unified dir wasn't that much different from the one already existing in teleport/src/component other than the latter one displayed a page indicator. DocumentNodes and other places now use the same kind of server side search panel. * Get rid of input search auto focus The auto focus can steal focus from other elements * Fix stories and snaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i merged this PR #44788 too early thinking it didn't have anything related to UI facing changes