pgevents: fix retention_period and disable_cleanup on crdb #46136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrato
approved these changes
Sep 3, 2024
rosstimothy
approved these changes
Sep 3, 2024
public-teleport-github-review-bot
bot
removed request for
marcoandredinis,
zmb3 and
hugoShaka
|
@espadolini See the table below for backport results.
|
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the CRDB row-level TTL configuration in the "pgevents" audit log storage driver to use a count of seconds for the
retention_period(rather than using nanoseconds interpreted as microseconds) in such a way that non representable values will result in an error rather than a silent overflow/underflow, and fixes the way we disable row-level TTL (as a result ofdisable_cleanup).Fixes #46125
Changelog: fixed retention period handling in the CockroachDB audit log storage backend