-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v2 static host user resource #46038
Conversation
Did we ever release the V1 resource? If not, can we make these changes without introducing a V2? |
The proto linter makes no exceptions for unreleased protos. The only way to achieve that would be to delete v1 and add it back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we be deleting v1 since it's not intended to be used and was never released?
2252866
to
f1d68ca
Compare
f1d68ca
to
6ac7b71
Compare
This change adds the v2 static host user resource.
6ac7b71
to
3376324
Compare
This change adds the v2 static host user resource.
This change adds the v2 static host user resource.
This change adds the v2 static host user resource.
In the v1 resource, more than one SHU resource with the same login but with conflicting other fields (groups, uid/gid, etc) could apply to a node. The host user's expected configuration would be ambiguous and sensitive to the order in which the resources were created.
In the v2 resource, only one resource can exist per login (the login is now the resource name to enforce this). The SHU resource contains a list of matchers to apply different configurations to different nodes:
If more than one matcher applies to the node, the node can reject the host user without needing to know about any other SHU resources.
Static host users aren't in any releases yet, so no need to worry about breaking changes.
Part of #42712.