remove protobuf fields for storing Jamf username, password, client_id and client_secret
#45957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrato
added
backport/branch/v14
no-changelog
|
Merge is pending on |
zmb3
approved these changes
Aug 28, 2024
…nt_id` and `client_secret` This PR builds on top of #45255 and removes the protobuf fields that could potencially be used to insecurely store Jamf secrets Signed-off-by: Tiago Silva <[email protected]>
tigrato
force-pushed
the
tigrato/drop-jamf-plugin-creds-fields
branch
from
7355906 to
922d75d
Compare
EdwardDowling
approved these changes
Aug 28, 2024
public-teleport-github-review-bot
bot
removed the request for review
from codingllama
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
…nt_id` and `client_secret` (#45957) This PR builds on top of #45255 and removes the protobuf fields that could potencially be used to insecurely store Jamf secrets Signed-off-by: Tiago Silva <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #45255 and removes the protobuf fields that could potentially be used to insecurely store Jamf secrets