remove windows desktop certs from client keyring #45939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklaassen
added
the
no-changelog
zmb3
approved these changes
Aug 28, 2024
espadolini
approved these changes
Aug 28, 2024
Comment on lines
-187
to
-188
| case p.RouteToWindowsDesktop.WindowsDesktop != "": | ||
| req.Target = &proto.IsMFARequiredRequest_WindowsDesktop{WindowsDesktop: &p.RouteToWindowsDesktop} |
There was a problem hiding this comment.
Should we add a default case here? Should've we always had a default case here?
There was a problem hiding this comment.
I don't think we ever end up here or else it's a logic bug, but that's not obvious at all, so added a default case that returns an error
public-teleport-github-review-bot
bot
removed the request for review
from capnspacehook
Co-authored-by: Zac Bergquist <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These aren't actually used in the client keyring anywhere, and clients never actually get desktop certs. These are the certs used for the desktop agent to dial to the windows desktop. They're only here for a
tctl auth signdebug command just to pass the cert der through to the file writer. When we actually generate these desktop certs in lib/srv/desktop we don't use the client keyring at all.I also removed
client.ReissueParams.RouteToWindowsDesktopwhich was never written to anywhere