[v15] Benchmarks Will Now Be Tested During CI #45867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding flags for benchmarks in unit test CI * Upping timeout for unit tests to accomodate benchmarks * Fixing a typo * Run benchmarks once * Adding a makefile target for ci bench test * Removing a stray quotation * Compacting workflow * Benchmarks now with nicer output * Benchmarks back to their own step * With error messages * Adding pipefail to preserve exit code * Using bash * Simpler command and including e * Separating benchmarks into its own workflow * Fixing benchmarks workflow name * Ignoring benchmarks that require root * Updating to account for root and nonroot bench * Cleaning up the benchmark workflows * Bench requires test log dir to be created * Excluding all BenchmarkRoot benchmarks from running * Bumping benchGetNodes timeout duration to account for some jitter * Fixing multiplexer benchmark by mirroring unit tests * Remembered that skip exists * Skipping BenchmarkGetMaxNodes due to flake * Fixing formatting of summary * Actually fixing summary * Adding another newline * Simplifying setup for mux listener * Excluding BenchmarkRootExecCommand
doggydogworld
requested review from
klizhentas,
russjones,
r0mant,
zmb3,
fheinecke,
camscale and
tcsc
as code owners
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
doggydogworld
added
the
no-changelog
rosstimothy
reviewed
Aug 26, 2024
Makefile
Outdated
Comment on lines
827
to
834
| test-go-bench: BENCHMARK_SKIP_PATTERN = "^BenchmarkRoot|^BenchmarkGetMaxNodes$$" | ||
| test-go-bench: | $(TEST_LOG_DIR) | ||
| go test -run ^$$ -bench . -skip $(BENCHMARK_SKIP_PATTERN) -benchtime 1x $(PACKAGES) \ | ||
| | tee $(TEST_LOG_DIR)/bench.txt | ||
|
|
||
| test-go-bench-root: PACKAGES = $(shell grep --exclude-dir api --include "*_test.go" -lr BenchmarkRoot . | xargs dirname | xargs go list | sort -u) | ||
| test-go-bench-root: BENCHMARK_PATTERN = "^BenchmarkRoot" | ||
| test-go-bench-root: BENCHMARK_SKIP_PATTERN = "^BenchmarkRootExecCommand$$" |
There was a problem hiding this comment.
I don't know that the exclusions for BenchmarkGetMaxNodes and BenchmarkRootExecCommand are required anymore
r0mant
approved these changes
Aug 26, 2024
rosstimothy
approved these changes
Aug 26, 2024
public-teleport-github-review-bot
bot
removed the request for review
from codingllama
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #44486 to branch/v15