[v16] WebDiscover: Improve RDS enrollment flow #45688
Conversation
|
@kimlisa - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
github-actions
bot
requested review from
GavinFrazar,
r0mant,
ravicious and
rudream
|
Should we wait for you to finish testing before approving? What troubles you had with the backport? If it's mostly related to the design components changes, it might be a good idea to forward this feedback to Bartosz. |
nah, i just want to run some tests and compare my PR merged into master side by side to gain my confidence back. most conflicts were easily resolvable (though I'm not sure why it was caused in the first place), it was the story where i had to stop and re-use the old storybook methods |
- user selects a vpc to see RDS's - restrict deploying service to user selected vpc - allow and require selecting subnets and security groups - refactor EnrollRdsDatabase.tsx into SingleEnrollment and AutoEnrollment - for self hosted, move configuring discovery config into own step - fixes a query bug where not all db servers were returning because possible duplicates were not accounted for (fixed by removing limit, default limit is 1k which should be plenty)
* Don't default to auto discover * Allow redpeploy when auto deploying and improve pending deploy hints * Allow overwrite existing dbs and skip on heartbeat timeout during enrollment * Remove allowing custom labels * Emit rest of discovery config event
Previously intended to determine if user already auto enrolled, but now that single and auto enrollment sets the same kind of labels for db_service, there is no distinction and can let user be blocked incorrectly.
kimlisa
force-pushed
the
lisa/v16/improve-rds
branch
from
692183f to
bcbc08b
Compare
public-teleport-github-review-bot
bot
removed request for
ravicious and
rudream
backport #44671 and #45179 to branch/v16
requires #45667
manual backport because of very painful storybook difference and design changes
there were so many conflicts that i'll go through the tests again 😢
Test plan:
changelog: Improve web UI enroll RDS flow where VPC, subnets, and security groups are now selectable