-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signing And Notarizing Plugins Targetting Darwin #45557
Conversation
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
2 similar comments
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM provided that this has gone through a dev build with results verified
Yeah here's the build: https://github.com/gravitational/teleport.e/actions/runs/10584369974/job/29328496089 It was run using related changes to workflow: https://github.com/gravitational/teleport.e/pull/4944 |
6da4aef
to
773f140
Compare
Purpose
Plugins that are build for darwin should be signed and notarized.
Implementation
Plugins that build for mac will now include the
darwin-signing.mk
at the root of the repository and use the function defined there for signing.changelog: Terraform provider plugin and event handler plugin are now signed and notarized for darwin releases.