improve max nodes benchmark #45545
Merged
improve max nodes benchmark #45545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fspmarshall
added
the
no-changelog
gabrielcorado
approved these changes
Aug 16, 2024
|
CI still doesn't look able to complete the test successfully |
fspmarshall
force-pushed
the
fspmarshall/improve-max-nodes-benchmark
branch
from
6940c38 to
b2f8712
Compare
fspmarshall
force-pushed
the
fspmarshall/improve-max-nodes-benchmark
branch
from
b2f8712 to
58fde66
Compare
rosstimothy
approved these changes
Aug 16, 2024
public-teleport-github-review-bot
bot
removed the request for review
from espadolini
rosstimothy
reviewed
Aug 16, 2024
Co-authored-by: rosstimothy <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
fspmarshall
added a commit
that referenced
this pull request
Aug 26, 2024
* improve max nodes benchmark * Update Makefile Co-authored-by: rosstimothy <[email protected]> --------- Co-authored-by: rosstimothy <[email protected]>
fspmarshall
added a commit
that referenced
this pull request
Aug 26, 2024
* improve max nodes benchmark * Update Makefile Co-authored-by: rosstimothy <[email protected]> --------- Co-authored-by: rosstimothy <[email protected]>
fspmarshall
added a commit
that referenced
this pull request
Aug 26, 2024
* improve max nodes benchmark * Update Makefile Co-authored-by: rosstimothy <[email protected]> --------- Co-authored-by: rosstimothy <[email protected]>
This was referenced Aug 26, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
* improve max nodes benchmark * Update Makefile --------- Co-authored-by: rosstimothy <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
* improve max nodes benchmark * Update Makefile --------- Co-authored-by: rosstimothy <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
* improve max nodes benchmark * Update Makefile --------- Co-authored-by: rosstimothy <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
* improve max nodes benchmark * Update Makefile --------- Co-authored-by: rosstimothy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#44486 added benchmarks to CI, but left
BenchmarkGetMaxNodesexcluded due to flake. This PR attempts to reduce flake by creating the nodes in a background goroutine asynchronously and switching from a per-event timeout to a single much longer timeout for all events to propagate. The intent is to get the nodes injected as fast as possible and allow for slop in replication time.