Enable debug service on default config #45464
Conversation
|
I'm getting that the debug level is INFO when But it'. not actually running the log at that. It's still on ERROR and not putting out any messages. You are able to set it a different level and then it works to go to that level. |
public-teleport-github-review-bot
bot
removed request for
eriktate,
jakule and
stevenGravy
I don't think this is related to this PR or the issue it is fixing. |
|
Update: I had to update the |
gabrielcorado
deleted the
gabrielcorado/enable-debug-service-default-cfg
branch
|
@gabrielcorado See the table below for backport results.
|
| @@ -594,6 +594,9 @@ func ApplyDefaults(cfg *Config) { | |||
| cfg.MaxRetryPeriod = defaults.MaxWatcherBackoff | |||
| cfg.Testing.ConnectFailureC = make(chan time.Duration, 1) | |||
| cfg.CircuitBreakerConfig = breaker.DefaultBreakerConfig(cfg.Clock) | |||
|
|
|||
| // Debug service defaults. | |||
| cfg.DebugService.Enabled = true | |||
There was a problem hiding this comment.
This introduced a regression. I believe it's now impossible to turn off the debug service through the config.
Connect My Computer turns off the debug service through the config to work around the problem with the path for the debug service socket being too long (see #43250 and #43267). Starting in v16.1.8, despite debug_service.enabled being set to false, the agent attempts to start the debug service which causes the error shown in #43250.
There was a problem hiding this comment.
Opened a PR to solve this (#46032). Thanks for reporting it 👍
Closes #45462.
When Teleport does not use a configuration file (either by providing a
--configflag or using the file at the default location), the configuration comes fromMakeDefaultConfig. When the debug service was added, its default value (enabled) was only added to theFileConfig, which is not used when creating the default configuration.This PR adds the missing debug service configuration to the default configuration.
changelog: Fixed debug service not enabled by default when not using a configuration file.