Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16] Fix OpenSSH guide sidebar highlighting #45279

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

ptgott
Copy link
Contributor

@ptgott ptgott commented Aug 8, 2024

Backports #45236

Currently, the agentless OpenSSH guide does not appear on the sidebar. This is because the sidebar generator expects menu pages to be named after their corresponding subdirectory and to exist at either (a) the same level as the subdirectory or (b) within the subdirectory. Since a page exists at both locations called openssh.mdx, the sidebar generator only shows one of these.

This change edits the OpenSSH guide to be called openssh-agentless.mdx so it appears on the sidebar.

Copy link

github-actions bot commented Aug 8, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions github-actions bot requested a review from mmcallister August 8, 2024 18:47
@stevenGravy stevenGravy added the no-changelog Indicates that a PR does not require a changelog entry label Aug 8, 2024
Copy link

github-actions bot commented Aug 8, 2024

🤖 Vercel preview here: https://docs-fie66vds7-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott force-pushed the paul.gottschling/45236-bp-v16 branch from c5e7544 to 3a18c23 Compare August 12, 2024 21:50
Copy link

🤖 Vercel preview here: https://docs-l6sz0v8qw-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott force-pushed the paul.gottschling/45236-bp-v16 branch from 3a18c23 to dd352f9 Compare August 14, 2024 21:08
Copy link

🤖 Vercel preview here: https://docs-6melggi61-goteleport.vercel.app/docs/ver/preview

Backports #45236

Currently, the agentless OpenSSH guide does not appear on the sidebar.
This is because the sidebar generator expects menu pages to be named
after their corresponding subdirectory and to exist at either (a) the
same level as the subdirectory or (b) within the subdirectory. Since a
page exists at both locations called `openssh.mdx`, the sidebar
generator only shows one of these.

This change edits the OpenSSH guide to be called `openssh-agentless.mdx`
so it appears on the sidebar.
@ptgott ptgott force-pushed the paul.gottschling/45236-bp-v16 branch from dd352f9 to f6bbe1f Compare August 15, 2024 12:21
Copy link

🤖 Vercel preview here: https://docs-347fupcka-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott added this pull request to the merge queue Aug 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 28, 2024
@ptgott ptgott added this pull request to the merge queue Aug 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 28, 2024
@ptgott ptgott added this pull request to the merge queue Aug 28, 2024
Merged via the queue into branch/v16 with commit 76c0b11 Aug 28, 2024
36 checks passed
@ptgott ptgott deleted the paul.gottschling/45236-bp-v16 branch August 28, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants