Use default labels when deploying service into ECS and allow overwriting existing DB (web) #45180
Conversation
kimlisa
requested review from
greedy52
and removed request for
tigrato and
Joerger
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
kimlisa
added
the
no-changelog
lib/web/integrations_awsoidc.go
Outdated
| databaseAgentMatcherLabels[types.DiscoveryLabelVPCID] = []string{req.VPCID} | ||
| databaseAgentMatcherLabels[types.DiscoveryLabelRegion] = []string{req.Region} | ||
| databaseAgentMatcherLabels[types.DiscoveryLabelAccountID] = []string{req.AccountID} |
There was a problem hiding this comment.
We are not checking this variables.
Does the UI always send them?
There was a problem hiding this comment.
thanks for catching this. here is the change
i left the merging of labels as is, just in case we want to bring back custom labels back in the future (probably not likely since we want to keep things as simple as possible), but atm the UI will no longer allow any custom labels
kimlisa
force-pushed
the
lisa/web-rds-backend-fields
branch
from
0beb819 to
678f00b
Compare
lib/web/integrations_awsoidc.go
Outdated
| if len(req.VPCID) == 0 { | ||
| return nil, trace.BadParameter("vpc ID is required") | ||
| } | ||
| if len(req.Region) == 0 { | ||
| return nil, trace.BadParameter("AWS region is required") | ||
| } | ||
| if len(req.AccountID) == 0 { | ||
| return nil, trace.BadParameter("AWS account ID is required") | ||
| } |
There was a problem hiding this comment.
💅
Checking for empty strings is usually done with == "" instead of using len.
I had to double check if those variables were string or lists 😅
kimlisa
force-pushed
the
lisa/web-rds-backend-fields
branch
from
678f00b to
d56d28f
Compare
public-teleport-github-review-bot
bot
removed the request for review
from GavinFrazar
…ing existing DB (web) (#45180) * Allow overwriting an existing database * Default to pre-defined labels when deploying service into ecs * Address CRs * Reuse create database endpoint to support overwrite Revert database update logic * Add checks for required fields for default labels
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
part of #41004
required by #45179