Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Protobuf types for SPIFFE Federation resource and audit events #45041

Merged
merged 5 commits into from
Aug 5, 2024
Merged

Add Protobuf types for SPIFFE Federation resource and audit events #45041

merged 5 commits into from
Aug 5, 2024

Conversation

strideynet
Copy link
Contributor

Part of #44861
As per #43348

Adds the Proto types for SPIFFEFederation resource and its associated audit events.

@strideynet strideynet added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 backport/branch/v16 labels Aug 5, 2024
@github-actions github-actions bot added audit-log Issues related to Teleports Audit Log size/md labels Aug 5, 2024
@github-actions github-actions bot requested review from jakule and lxea August 5, 2024 10:52
@capnspacehook
Copy link
Contributor

capnspacehook commented Aug 5, 2024 •
edited
Loading

Now that I got #44632 merged, would you mind adding to eventsMap in lib/events/events_test.go please? It tests that audit events can be converted and processed correctly. If it was in master when you opened the PR and you added a test case for it it would have caught that you didn't add an entry in lib/events/dynamic.go for example

@strideynet strideynet enabled auto-merge August 5, 2024 14:53
@strideynet strideynet added this pull request to the merge queue Aug 5, 2024
Merged via the queue into master with commit 9be1cc9 Aug 5, 2024
38 checks passed
@strideynet strideynet deleted the strideynet/add-protos-for-spiffe-federation branch August 5, 2024 15:27
@public-teleport-github-review-bot
Copy link

@strideynet See the table below for backport results.

Branch Result
branch/v15 Failed
branch/v16 Failed

strideynet added a commit that referenced this pull request Aug 8, 2024
@strideynet
Add Protobuf types for SPIFFE Federation resource and audit events (#…
eff4f98 
…45041)

* Add gRPC types and events for SPIFFEFederation type

* Fix copy-pasta mistake

* Add to dynamic.go

* Add to eventsmap
@strideynet strideynet mentioned this pull request Aug 8, 2024
Merged
strideynet added a commit that referenced this pull request Aug 8, 2024
@strideynet
Add Protobuf types for SPIFFE Federation resource and audit events (#…
353da55 
…45041)

* Add gRPC types and events for SPIFFEFederation type

* Fix copy-pasta mistake

* Add to dynamic.go

* Add to eventsmap
@strideynet strideynet mentioned this pull request Aug 8, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 8, 2024
@strideynet
Add Protobuf types for SPIFFE Federation resource and audit events (#…
84f8ccc 
…45041) (#45243)

* Add gRPC types and events for SPIFFEFederation type

* Fix copy-pasta mistake

* Add to dynamic.go

* Add to eventsmap
github-merge-queue bot pushed a commit that referenced this pull request Aug 8, 2024
@strideynet
Add Protobuf types for SPIFFE Federation resource and audit events (#…
03795f9 
…45041) (#45244)

* Add gRPC types and events for SPIFFEFederation type

* Fix copy-pasta mistake

* Add to dynamic.go

* Add to eventsmap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capnspacehook capnspacehook capnspacehook approved these changes

@smallinsky smallinsky smallinsky approved these changes

@tigrato tigrato tigrato approved these changes

Assignees
No one assigned
Labels
audit-log Issues related to Teleports Audit Log backport/branch/v15 backport/branch/v16 no-changelog Indicates that a PR does not require a changelog entry size/md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@strideynet @capnspacehook @tigrato @smallinsky