Fix rare TestResumption deadlock #44810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espadolini
added
the
no-changelog
rosstimothy
approved these changes
Jul 30, 2024
zmb3
approved these changes
Jul 30, 2024
tigrato
approved these changes
Jul 30, 2024
|
@espadolini See the table below for backport results.
|
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables the periodic reconnection ticker before running the reconnection-on-drop loop instead of resetting the ticker at the end of the loop. This enables TestResumption to correctly wait for the ticker to be running before advancing the fake clock that triggers the periodic reconnection in the test, which can very rarely deadlock in tests. The observable behavior of the resumable connection client is unaltered.