[v16] fix: Issue DeviceWebToken during Github authn #44808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingllama
added
the
no-changelog
codingllama
commented
Jul 30, 2024
There was a problem hiding this comment.
We got various conflicts here related to the split TLS/SSH private keys, all reverted.
codingllama
commented
Jul 30, 2024
There was a problem hiding this comment.
Protogen conflicts solved by make grpc.
rosstimothy
approved these changes
Jul 30, 2024
* Move trusted device mode calculation into CreateWebSessionFromReq * Add the GithubAuthRequest.ClientUserAgent field * Update generated protos * Issue DeviceWebToken during Github authn * Issue DeviceWebToken as part of CreateWebSessionFromReq * nit: Move methods to sessions.go
codingllama
force-pushed
the
codingllama/backport/44656-v16
branch
from
418b36e to
c41dce3
Compare
|
Rebased and fixed conflicts on lib/auth/sessions.go (imports only). |
jakule
approved these changes
Jul 30, 2024
public-teleport-github-review-bot
bot
removed the request for review
from r0mant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #44656 to branch/v16.
#44598