Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to using tctl desktop ls #44735

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Change to using tctl desktop ls #44735

merged 2 commits into from
Jul 29, 2024

Conversation

webvictim
Copy link
Contributor

@webvictim webvictim commented Jul 29, 2024 •
edited
Loading

tctl get windows_desktop -> tctl desktop ls

@webvictim
Change to using tctl desktops ls
b895e94 
`tctl get windows_desktop` -> `tctl desktops ls`
@webvictim webvictim requested review from stevenGravy and oshati July 29, 2024 12:56
@webvictim webvictim self-assigned this Jul 29, 2024
@github-actions GitHub Actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@webvictim webvictim added the no-changelog Indicates that a PR does not require a changelog entry label Jul 29, 2024
@stevenGravy
Copy link
Contributor

Given this changes a command would recommend adding a changelog in this.

zmb3
zmb3 approved these changes Jul 29, 2024
View reviewed changes
docs/pages/choose-an-edition/migrate-to-cloud.mdx Outdated Show resolved Hide resolved
@zmb3
Copy link
Collaborator

zmb3 commented Jul 29, 2024

Given this changes a command would recommend adding a changelog in this.

This is a docs update. We don't need a changelog entry in release notes because no functional changes are included in any release.

@stevenGravy
Copy link
Contributor

Given this changes a command would recommend adding a changelog in this.

This is a docs update. We don't need a changelog entry in release notes because no functional changes are included in any release.

my mistake in reading it. sure

@webvictim webvictim changed the title Change to using tctl desktops ls Change to using tctl desktop ls Jul 29, 2024
@webvictim webvictim enabled auto-merge July 29, 2024 16:35
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-54xs9v6sw-goteleport.vercel.app/docs/ver/preview

@webvictim webvictim added this pull request to the merge queue Jul 29, 2024
Merged via the queue into master with commit 6b2d927 Jul 29, 2024
39 of 40 checks passed
@webvictim webvictim deleted the gus/docs/cloud-migration-tctl-desktops branch July 29, 2024 17:02
@public-teleport-github-review-bot
Copy link

@webvictim See the table below for backport results.

Branch Result
branch/v15 Create PR
branch/v16 Create PR

This was referenced Jul 29, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptgott ptgott ptgott approved these changes

@zmb3 zmb3 zmb3 approved these changes

Assignees

@webvictim webvictim

Labels
backport/branch/v15 backport/branch/v16 documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@webvictim @stevenGravy @zmb3 @ptgott