Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate S3 uploader to aws-sdk-go-v2 #44728

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Migrate S3 uploader to aws-sdk-go-v2 #44728

merged 1 commit into from
Aug 20, 2024

Conversation

rudream
Copy link
Contributor

@rudream rudream commented Jul 29, 2024

Purpose

This PR solves #39248

This PR updates our S3 uploader to use the aws-sdk-go-v2 package as opposed to V1.

@rudream rudream force-pushed the yassine/uploader-aws-v2 branch from 3104fc6 to 4f9fe11 Compare August 1, 2024 00:35
@rudream rudream marked this pull request as ready for review August 1, 2024 01:14
@rudream rudream added the no-changelog Indicates that a PR does not require a changelog entry label Aug 1, 2024
@rudream rudream requested review from rosstimothy and zmb3 August 1, 2024 01:14
@github-actions github-actions bot added audit-log Issues related to Teleports Audit Log size/sm labels Aug 1, 2024
@rudream rudream force-pushed the yassine/uploader-aws-v2 branch from 4f9fe11 to 6eab770 Compare August 8, 2024 05:55
rosstimothy
rosstimothy reviewed Aug 8, 2024
View reviewed changes
lib/events/s3sessions/s3handler.go Outdated Show resolved Hide resolved
lib/events/s3sessions/s3stream.go Outdated Show resolved Hide resolved
@rudream rudream requested a review from rosstimothy August 9, 2024 15:22
@rudream rudream force-pushed the yassine/uploader-aws-v2 branch from 739fc4b to ca1bcd3 Compare August 16, 2024 06:59
zmb3
zmb3 approved these changes Aug 16, 2024
View reviewed changes
lib/events/s3sessions/s3stream.go Show resolved Hide resolved
@rudream rudream force-pushed the yassine/uploader-aws-v2 branch from ca1bcd3 to 026765c Compare August 20, 2024 18:02
@rudream rudream force-pushed the yassine/uploader-aws-v2 branch from 026765c to e7f5555 Compare August 20, 2024 18:32
@rudream rudream added this pull request to the merge queue Aug 20, 2024
@rudream rudream removed this pull request from the merge queue due to a manual request Aug 20, 2024
@rudream rudream enabled auto-merge August 20, 2024 18:57
@rudream rudream added this pull request to the merge queue Aug 20, 2024
Merged via the queue into master with commit a47041b Aug 20, 2024
40 checks passed
@rudream rudream deleted the yassine/uploader-aws-v2 branch August 20, 2024 19:17
@public-teleport-github-review-bot
Copy link

@rudream See the table below for backport results.

Branch Result
branch/v16 Create PR

@rudream rudream mentioned this pull request Aug 20, 2024
Closed
rudream added a commit that referenced this pull request Aug 21, 2024
@rudream
migrate uploader to aws-sdk-go-v2 (#44728)
b49b907
@zmb3 zmb3 mentioned this pull request Aug 24, 2024
Closed
@hugoShaka hugoShaka mentioned this pull request Nov 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosstimothy rosstimothy rosstimothy approved these changes

@zmb3 zmb3 zmb3 approved these changes

Assignees
No one assigned
Labels
audit-log Issues related to Teleports Audit Log backport/branch/v16 no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rudream @zmb3 @rosstimothy