Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16] RFD 173 implementation: Terraform provider UX improvements #44690

Merged
merged 6 commits into from
Aug 26, 2024

Conversation

hugoShaka
Copy link
Contributor

@hugoShaka hugoShaka commented Jul 26, 2024

MERGE THIS BEFORE RELEASING 16.2

This PR backports the complete RFD 173 implementation to branch/v16.

Backported PRs are:

Changelog: Add a tctl terraform env command to simplify running the Teleport Terraform provider locally.
Changelog: Add native MachineID support to the Terraform provider. Environments with delegated joining methods such as GitHub Actions, GitLab CI, CircleCI, GCP, or AWS can run the Terraform provider without having to setup tbot.
Changelog: The Terraform Provider now sequentially tries every credential source and provide more actionable error messages if it cannot connect.
Changelog: When the Terraform provider finds expired credentials it will now fail fast with a clear error instead of hanging for 30 seconds and sending potentially misleading error about certificates being untrusted.

Copy link

🤖 Vercel preview here: https://docs-qv61vdk6s-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-95p6wp3z7-goteleport.vercel.app/docs/ver/preview

@hugoShaka hugoShaka force-pushed the hugo/backport-rfd173-to-branch/v16 branch from e238e1a to 7852fa3 Compare August 1, 2024 15:27
Copy link

github-actions bot commented Aug 1, 2024

🤖 Vercel preview here: https://docs-l458ncr1r-goteleport.vercel.app/docs/ver/preview

@hugoShaka hugoShaka force-pushed the hugo/backport-rfd173-to-branch/v16 branch from 7852fa3 to 63766c1 Compare August 2, 2024 22:06
Copy link

github-actions bot commented Aug 2, 2024

🤖 Vercel preview here: https://docs-eq3ilohu1-goteleport.vercel.app/docs/ver/preview

Copy link

github-actions bot commented Aug 2, 2024

🤖 Vercel preview here: https://docs-lkntynwc4-goteleport.vercel.app/docs/ver/preview

@hugoShaka hugoShaka marked this pull request as ready for review August 2, 2024 23:19
@public-teleport-github-review-bot

@hugoShaka - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes.

@hugoShaka
Copy link
Contributor Author

Requires: #45101

@hugoShaka hugoShaka force-pushed the hugo/backport-rfd173-to-branch/v16 branch from 4e1236d to 55dda2d Compare August 6, 2024 16:18
Copy link

github-actions bot commented Aug 6, 2024

🤖 Vercel preview here: https://docs-hii4rfvgj-goteleport.vercel.app/docs/ver/preview

@r0mant r0mant added the release-16.2 To be released in v16.2 label Aug 15, 2024
hugoShaka and others added 5 commits August 26, 2024 08:55
* Introduce the `tctl terrafor env` command

* fix tests

* address marco's feedback + use correct b64 lib

* add license

* add created-by label as specified in the RFD

* Update tool/tctl/common/terraform_command.go

Co-authored-by: Roman Tkachenko <[email protected]>

* Apply suggestions from code review

Co-authored-by: Roman Tkachenko <[email protected]>

* Have telpeort create the Terraform default role

* rename use-existing-role -> role, and stop hijacking identity.SSHCACertBytes

* Make the terraform provider role a real preset, rename to 'terraform-provider'

* lint

* Fix tbot's invocation after rebase

---------

Co-authored-by: Roman Tkachenko <[email protected]>
* Refactor Terraform credential loading

* Warn about expiry

* kip expired credentials

* fixup! kip expired credentials

* Use constants everywhere + add godocs

* fixup! Use constants everywhere + add godocs

* Address marco's feedback

* fixup! Address marco's feedback

* tidy go mod

* lint

* re-render TF docs
* Add Terraform Provider native MachineID support

* Reject 'token' join method

* lint: fix imports

* re-render TF docs

* fix tests + add license

* lint
Copy link

🤖 Vercel preview here: https://docs-q1qjkdkr6-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-9xwsadr1b-goteleport.vercel.app/docs/ver/preview

@marcoandredinis marcoandredinis added this pull request to the merge queue Aug 26, 2024
Merged via the queue into branch/v16 with commit 9d61809 Aug 26, 2024
39 checks passed
@marcoandredinis marcoandredinis deleted the hugo/backport-rfd173-to-branch/v16 branch August 26, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants