[v16] Remove S3 fields from AWS OIDC IdP set up command #44679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
added
the
no-changelog
flyinghermit
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
LGTM based on assumption that this command is not really that commonly used.
Otherwise, if we are backporting and this command is commonly used, it might create confusion for user if the argument wouldn't suddenly respond as they intended.
In that case, handeling --s3-bucket-uri argument and responding with "this command is no longer supported and will be removed in v17" would be useful.
|
I think it's fine. |
tigrato
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #44507 to branch/v16