[devicetrust] fix: handle server errors in bi-directional streams #44677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrato
commented
Jul 26, 2024
lib/devicetrust/authn/authn.go
Outdated
| // The client only sees the server's error when it tries to read from the stream. | ||
| // This function repeatedly calls Recv to surface the first error encountered. | ||
| // Use this function when the stream's content is irrelevant and only the error matters. | ||
| func consumeStreamToError(sendErr error, stream devicepb.DeviceTrustService_AuthenticateDeviceClient) error { |
There was a problem hiding this comment.
I defined this function 3 times to avoid making any of these functions publicly available in api to avoid people incorrectly using them.
If you guys prefer it to be moved, I am ok with it
Moved to api/utils since there are tons of bad usage in our codebase
Fix an edge case in the devicetrust gRPC bi-directional stream handler where the stream could terminate with an error after the last client `Recv` call but before the next `Send` call. Previously, this scenario caused the `Send` method to return an `io.EOF` error, which indicated that the connection was terminated but did not reveal any errors returned by the server. This update ensures that the client continues to consume the stream until an error is returned, allowing for proper error handling and more robust stream management. Signed-off-by: Tiago Silva <[email protected]>
tigrato
force-pushed
the
tigrato/fix-grpc-bi-streaming-err
branch
from
61e4ff8 to
1d57fab
Compare
codingllama
reviewed
Jul 26, 2024
codingllama
approved these changes
Jul 29, 2024
strideynet
approved these changes
Jul 30, 2024
public-teleport-github-review-bot
bot
removed the request for review
from camscale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an edge case in the devicetrust gRPC bi-directional stream handler where the stream could terminate with an error after the last client
Recvcall but before the nextSendcall. Previously, this scenario caused theSendmethod to return anio.EOFerror, which indicated that the connection was terminated but did not reveal any errors returned by the server. This update ensures that the client continues to consume the stream until an error is returned, allowing for proper error handling and more robust stream management.Changelog: Ensure Device Trust clients correctly handle server errors on abruptly terminated streams.