update NewTestCAWithConfig to use RSA key for SAML IdP CA
#44670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyinghermit
added
the
no-changelog
camscale
approved these changes
Jul 26, 2024
hugoShaka
approved these changes
Jul 26, 2024
public-teleport-github-review-bot
bot
removed the request for review
from nklaassen
|
Let's support ECDSA instead! https://github.com/gravitational/teleport.e/pull/4764 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NewTestCAWithConfigfunction was recently updated to useECDSAP256(#44418) as a default algorithm to generate private key.Unfortunately, the SAML IdP still uses xmldsig RSA SHA256 signature method (http://www.w3.org/2001/04/xmldsig-more#rsa-sha256) to sign the SAML assertion, so the signing key must be an RSA key.
Fixes test in this PR https://github.com/gravitational/teleport.e/pull/4732 that uses
eweb test suite to test SAML auth middleware.