Explicit that TF reference is generated #44667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
requested review from
klizhentas,
russjones,
r0mant,
zmb3,
fheinecke,
camscale,
tcsc,
rosstimothy and
codingllama
as code owners
hugoShaka
added
no-changelog
github-actions
bot
requested review from
marcoandredinis,
mmcallister,
ptgott,
tigrato and
xinding33
hugoShaka
changed the title
|
🤖 Vercel preview here: https://docs-1jhyhj2xy-goteleport.vercel.app/docs/ver/preview |
fheinecke
approved these changes
Jul 25, 2024
marcoandredinis
approved these changes
Jul 26, 2024
tigrato
approved these changes
Jul 26, 2024
public-teleport-github-review-bot
bot
removed request for
mmcallister,
xinding33 and
ptgott
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
@hugoShaka See the table below for backport results.
|
hugoShaka
added a commit
that referenced
this pull request
Jul 26, 2024
* Add comment warning that tf ref is generated * trigger CI on TF ref changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR warns users that TF ref should not be manually edited and triggers the CI on manual changes so we don't mistakenly try to edit the TF ref.