Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v15] Support detecting a credential expiry #44658

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

hugoShaka
Copy link
Contributor

@hugoShaka hugoShaka commented Jul 25, 2024

Manual backport of #43886 to branch/v15.

This backport contains the backward compatibility code from the v16 backport.

* Support detecting a credential expiry (#43886)

* Support detecting a credential expiry

* Fix Expiry() and add tests

* protect identityFile cred with a lock

* add godoc

* Fix tests

* Do not break previous Credentials implementations

* fixup! Do not break previous Credentials implementations

* address edoardo's comments

* fix tests
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@hugoShaka hugoShaka changed the title [v16] Support detecting a credential expiry (#44080) [v15] Support detecting a credential expiry (#44080) Jul 25, 2024
@hugoShaka hugoShaka added the no-changelog Indicates that a PR does not require a changelog entry label Jul 25, 2024
@hugoShaka hugoShaka requested review from espadolini and Joerger and removed request for marcoandredinis, timothyb89 and tigrato July 25, 2024 20:37
@hugoShaka hugoShaka changed the title [v15] Support detecting a credential expiry (#44080) [v15] Support detecting a credential expiry Jul 25, 2024
@hugoShaka hugoShaka enabled auto-merge July 25, 2024 21:23
@hugoShaka hugoShaka added this pull request to the merge queue Jul 26, 2024
Merged via the queue into branch/v15 with commit 043d690 Jul 26, 2024
35 of 38 checks passed
@hugoShaka hugoShaka deleted the hugo/backport-43886-to-branch/v15 branch July 26, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport machine-id no-changelog Indicates that a PR does not require a changelog entry size/md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants