Reuse existing SAMLConnector signing key when possible #44655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
zmb3
approved these changes
Jul 25, 2024
timothyb89
approved these changes
Jul 25, 2024
public-teleport-github-review-bot
bot
removed the request for review
from AntonAM
|
@hugoShaka See the table below for backport results.
|
tigrato
pushed a commit
that referenced
this pull request
Sep 23, 2024
* Reuse existing SAMLConnector signing key when possible * lint
This was referenced Sep 23, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
* Reuse existing SAMLConnector signing key when possible * lint Co-authored-by: Hugo Shaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9104
Changelog: Teleport no longer creates invalid SAML Connectors when calling
tctl get saml/<connector-name> | tctl create -fwithout the--with-secretsflag.