discover: generate config with --silent flag #44597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you add a node through the discover flow, we use the teleport node configure command to generate a configuration file, and then we actually start Teleport. By default, the configure command prints some hint messages telling the user to run teleport start, but this is not necessary in the discover flow since we start it up for you. The --silent command was added to solve this, but we never went back and updated the install script to use it. Closes #29518
zmb3
added
no-changelog
r0mant
approved these changes
Jul 24, 2024
rosstimothy
approved these changes
Jul 24, 2024
public-teleport-github-review-bot
bot
removed request for
gabrielcorado and
fspmarshall
This was referenced Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you add a node through the discover flow, we use the teleport node configure command to generate a configuration file, and then we actually start Teleport.
By default, the configure command prints some hint messages telling the user to run teleport start, but this is not necessary in the discover flow since we start it up for you.
The --silent command was added to solve this, but we never went back and updated the install script to use it.
Closes #29518