Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pnpm storybook fail with clear error if certs are not set up #44589

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

ravicious
Copy link
Member

@ravicious ravicious commented Jul 24, 2024

Running Storybook now requires certs to be set up in web/certs. This PR adds relevant information to the readme and makes pnpm storybook fail if web/certs/server.crt is missing.

@ravicious ravicious added the no-changelog Indicates that a PR does not require a changelog entry label Jul 24, 2024
@github-actions github-actions bot requested review from kimlisa and rudream July 24, 2024 08:57
@ravicious ravicious changed the title Add note in web README about certs for Storybook Make pnpm storybook fail with clear error if certs are not set up Jul 24, 2024
@ravicious ravicious added this pull request to the merge queue Jul 24, 2024
Merged via the queue into master with commit f03639b Jul 24, 2024
40 checks passed
@ravicious ravicious deleted the r7s/storybook-certs-readme branch July 24, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants